search

sns-sdks / python-facebook

A simple Python wrapper for facebook graph api :sparkles: :cake: :sparkles: .
https://sns-sdks.github.io/python-facebook/
322 stars 84 forks source link

refactor some graph's class attributes, create constants #218

Closed lucas-montes closed 8 months ago

lucas-montes commented 1 year ago

First of all your library seems very nice (a little over-engineered maybe?). I think that there are a few methods that are too large and could be reduced and separated. Also some parameters could have a better name. Of course it's only my opinion, I'm just sharing my thoughts, but the overall library is a really great piece of code.

I've done some changes. I need to pass the linters and add some tests. Let me know if it seems ok to you these changes.

For some tests I get: FAILED tests/test_graph.py::test_request_error - requests.exceptions.ConnectionError: Connection refused by Responses - the call doesn't match any registered mock.

MerleLiuKun commented 1 year ago

oh, welcome to pr, I will take a look at this weekend.

MerleLiuKun commented 1 year ago

Hi, sorry for late reply,

Recently, I have not had enough time to look into this, so maybe I need a little more time.:)