search

snss231 / pe

0 stars 0 forks source link

Error message does not match error for invalid date in reminders #11

Open snss231 opened 2 years ago

snss231 commented 2 years ago

reminder command does not give the user good information about why the date is invalid (in this case, the day is invalid because February 2022 only has 28 days), leading to confusion

image.png

nus-se-script commented 2 years ago

Team's Response

2022-02-29 is not a valid date. Since the date does not exist on a calendar, it cannot be considered a date in the format YYYY-MM-DD. As such, it is correct to tell the user that they gave the wrong parameters. i.e. same as giving 1Q84-01-04, it is an invalid date and throws a format error.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]