snstac / pytak

PyTAK is a Python package for rapid TAK integration.
https://pytak.readthedocs.io/en/stable/
Apache License 2.0
162 stars 45 forks source link

fix tls errors #15

Closed sei-jmattson closed 2 years ago

sei-jmattson commented 2 years ago

Ironed out TLS with your v5 stuff.
get_tls_config() wasn't passing the config and reordered the don't checks to prevent error setting ssl_ctx.verify_mode = ssl.CERT_NONE while ssl_ctx.check_hostname was still true.

sei-jmattson commented 2 years ago

Was going to tackle the tests and rename stuff in the comments, but figured you might beat me to it.

ampledata commented 2 years ago

Wow, caught me before I finished v5. Thanks so much!

sei-jmattson commented 2 years ago

Well, was in the middle of coding against and browsed the source several times yesterday. Then was suprised today when it was all different! :) So I struck while the iron was hot! What is your time frame for releasing v5...best guess?

ampledata commented 2 years ago

This week! Promise! If you want to discuss changes in real-time hit me up: Signal/WhatsApp: +1-310-621-9598 or we can do a call.