search

snstac / pytak

PyTAK is a Python package for rapid TAK integration.
https://pytak.readthedocs.io/en/stable/
Apache License 2.0
156 stars 42 forks source link

Retain backward compatibility #35

Closed pcmarmotte closed 1 year ago

pcmarmotte commented 1 year ago

The full config is not necessary for the CLITool class. This could potentially break any tool previously created using more than one ctor argument. I suggest to remove this new initialization parameter.

One can still create multiple connections with more subsections having their own config passed using the create_workers method.

ampledata commented 1 year ago

@pcmarmotte thanks for sending this over. Did you hit this as a bug in a PyPI or DEB package per chance? I'd hoped not to ship any packages with API breaking changes, especially this new 'multi-connect' behavior.

pcmarmotte commented 1 year ago

No I was experimenting with the github version.