snsten / Klein-zmk

ZMK Firmware for Klein keyboard
MIT License
29 stars 29 forks source link

Add BLU layer on Tab key, VOL reverse, BT func #3

Closed idesignstuff closed 1 year ago

idesignstuff commented 1 year ago
snsten commented 1 year ago

I think the &bt BT_CLEAR should be placed somewhere else since there's risk of wrongly pressing the key at it's current position and clearing the bluetooth connection.

It could be placed next to Caps Lock on Nav Layer or on the Blu layer along with rest of bluetooth specific commands.

Rest of the chages looks good.

idesignstuff commented 1 year ago

And GH actions still failing to build uf2 artifacts for left and right, but not settings reset. SMH

Error looks like this: devicetree error: /__w/Klein-zmk/Klein-zmk/config/boards/shields/klein/klein.keymap:43 (column 121): parse error: expected number or parenthesized expression

And line 43 looks like this: &lt MEDIA ESC &lt NAV SPACE &kp TAB &bootloader &bootloader &lt SYM RET &lt NUM BKSP &lt FUN DEL character 121 appears to be in &lt SYM RET but when the line is pasted in here, the whitespace is removed.