search

snu-quiqcl / iquip

Ion trap Quantum computing User Interface Project
GNU General Public License v3.0
7 stars 0 forks source link

Aijuh/237/basic scannable display #239

Closed Aijuh closed 10 months ago

Aijuh commented 11 months ago

This closes #237.

Add a new widget at builderFrame and builderApp for Scannable argument display. Below image shows scannable widget when all features are added. In this PR, only framework of Scannable widget is done.

temp_ra

  1. Add new widget for scannable entry at builderFrame.
  2. Add dummy ScanEntry.

Additional code will be added at next PR.

Aijuh commented 10 months ago

I fixed indentations inside docstrings. As for _Scan_Entry class, I will add codes inside that class and use it for further implementation. As for "TO DO" docstring, It is hard to find exact place to add it, becase those classes are not part of _ScanEntry class.

Aijuh commented 10 months ago

image I believe this code moved to line 298 of and fixed.

BECATRUE commented 10 months ago

As for _Scan_Entry class, I will add codes inside that class and use it for further implementation. As for "TO DO" docstring, It is hard to find exact place to add it, becase those classes are not part of _ScanEntry class.

I'm still confused whether you will add more classes or use only this class.

Aijuh commented 10 months ago

I changed docstring as requested. If you see this issue, new class for RangeScan layout will be mabe in next PR. This RangeScan class will be defined outside of ScanEntry class. ScanEntry makes all scan type layout and gather them to one stackwidget.

BECATRUE commented 10 months ago

Oh, I see! Thanks for your explanation.

Aijuh commented 10 months ago

It was good idea to divide scannable PR into small pieces. I will double check docstring from the next PR.