snu-quiqcl / iquip

Ion trap Quantum computing User Interface Project
GNU General Public License v3.0
7 stars 0 forks source link

Updated pylint complains about the number of positional arguments #318

Open kangz12345 opened 6 days ago

kangz12345 commented 6 days ago

As the recent pylint now checks the number of positional arguments, we should update our codes or .pylintrc. Because of this, my new PRs do not pass the pylint check.

I will suggest how we should do about this. Feel free to give your opinions!

See also: https://pylint.readthedocs.io/en/stable/whatsnew/3/3.3/index.html#new-checks

kangz12345 commented 6 days ago

There are quite a lot of cases where the positional arguments are more than 5, so how about setting the max-positional-arguments to 10 in .pylintrc for now? Later we can update the code to make positional arguments less than 5, and remove the max-positional-arguments option. @BECATRUE

kangz12345 commented 5 days ago

We are going to update codes to make positional arguments less than 5 later.