search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
6 stars 2 forks source link

Kangz12345/110/replace bus with queued connection #112

Closed kangz12345 closed 1 year ago

kangz12345 commented 1 year ago

Please see the related issue #110 for details.

Now there is no actual buses. Instead, only the subscription information is managed.

This closes #110.

kangz12345 commented 1 year ago

Note that I didn't change the setup.json file. It is not a problem, but it is bad since it contains redundant information. If you think the "bus" part of the setup file should be removed, I will.

kangz12345 commented 1 year ago

Please note that this PR may conflict (not technically) with #107, since some methods are removed from Swift. My suggestion is, merge this PR (if there is no problem with this PR) first, and do not test the removed methods in #107. It may yield low coverage, but is not a problem after merging it.

BECATRUE commented 1 year ago

Note that I didn't change the setup.json file. It is not a problem, but it is bad since it contains redundant information. If you think the "bus" part of the setup file should be removed, I will.

I think that the setup.json file should be removed as it is a part of examples and it should fit the specs perfectly. And I think it may confuse a newcomer.