Closed BECATRUE closed 1 year ago
The testing result is like below:
It is also shown in GitHub Action details.
In addition, why isn't there a test for createApp()
?
In addition, why isn't there a test for
createApp()
?
I doesn't test it because it is called automatically by the constructor.
And also, I tested with two diffrent app infos, so all functions in createApp()
were checked.
First of all, I updated it up to where I modified it.
I applied all reviews.
In test_broadcast()
, I called _broadcast()
with all buses and checked if each app is called by the number of buses it subcribes to.
In test_destroy_app()
, I destroyed all apps and checked if self.swift._apps
is empty.
I updated it! @kangz12345
This PR will close #107.
I implemented all tests in
swift.swift
.During tests, I found a minor bug in
Swift
class. IncreateApp()
, we addedQDockWidget
s toself.mainWindow
as below:However, if
area
arguments isQt.AllDockWidgetAreas
, the warning occurs like below:Thus, as a solution, I changed it into
Qt.LeftDockWidgetArea
.If you think it should be separated into new issue, I will do so.