snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Fix the error not working all original message transfer protocol #140

Closed BECATRUE closed 1 year ago

BECATRUE commented 1 year ago

Yet, this PR is not completed. Just related to #137.

The problem is all broadcast-receive examples are not working, because it is only encoded by broadcast(), not decoded. So, each communication occurs an error like below.

img

To fix it, I replaced all direct emit() into broadcast() and changed the receiving part a little.

BECATRUE commented 1 year ago

First of all, I only modified numgen, dbmgr, and logger. Please leave your opinion about these three apps!

BECATRUE commented 1 year ago

I applied all reviews!

BECATRUE commented 1 year ago

I completely forgot fixing other apps.. I will make another PR.