Closed BECATRUE closed 1 year ago
When do we need the update
feature?
A question emerges now: why did we give the
show
option for each app, not frame? 😅
I have the same question, too..😂
However, we cannot determine how many frames will be returned by frames()
, so I think using one unified show
is the best.
When do we need the
update
feature?
Umm.. It's just a abstract situation, but I think that we may want to reopen a frame for re-initializing. If you think it is not necessary, I will remove it.
Umm.. It's just a abstract situation, but I think that we may want to reopen a frame for re-initializing. If you think it is not necessary, I will remove it.
However, if we re-initialize (hence re-instantiate) a frame, then the instance is changed, i.e., it is replaced with a different frame.
Therefore, the previous frame widget instance will be removed and the new instance be added even when update=False
, I guess..!
Umm.. It's just a abstract situation, but I think that we may want to reopen a frame for re-initializing. If you think it is not necessary, I will remove it.
However, if we re-initialize (hence re-instantiate) a frame, then the instance is changed, i.e., it is replaced with a different frame. Therefore, the previous frame widget instance will be removed and the new instance be added even when
update=True
, I guess..!
Oh, you're right.. I will remove it🥲
I applied the reviews and push the test branch BECATRUE/149/update-frames-test
.
In the test, when started, in numgen
, there is only one frame generatorFrame
.
Then, if you generate a number, viewerFrame
will be opened.
I applied the reviews, again! Plz check it.
I applied the reviews, again! Plz check it.
I think you didn't push your work! @BECATRUE
I applied the reviews, again! Plz check it.
I think you didn't push your work! @BECATRUE
I updated now.. Sorry🥲
This PR will close #149.
I implemented a swift-call
updateFrames()
which updates frames of the target app.It has two arguments: