search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Testing for updated parts #161

Closed BECATRUE closed 1 year ago

BECATRUE commented 1 year ago

This will close #144.

In this issue, I tested all classes and functions in swift module.

For each class, it is implemented as each test class, such as SwiftTest. In the above class, for each method is implemented as each method, such as test_blabla(). I didn't implement tests for methods which are called when the class instance is initiated, e.g. create_app().

And also, I realized a small bug in subscribe() in terms of type, so that I fixed it.

The coverage is 100%!

kangz12345 commented 1 year ago

Please summarize what you did in this PR!

BECATRUE commented 1 year ago

I updated the reviews! But it isn't implemented yet about subscribe(). And after you approve this PR, I will move out the test file as we discussed in #144.

BECATRUE commented 1 year ago

I applied the reviews! @kangz12345

BECATRUE commented 1 year ago

I applied your reviews!

BECATRUE commented 1 year ago

Oh, I move the test file out of tests directory! Please re-check it. @kangz12345