snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Version release 2.0.0 #169

Closed kangz12345 closed 1 year ago

kangz12345 commented 1 year ago

I think we have to release a new version tag 2.0.0 as we updated the readme! Please resolve this as you have done it before @BECATRUE !

BECATRUE commented 1 year ago

I saved the draft of this release! Please check it in 'Releases' tab. @kangz12345

kangz12345 commented 1 year ago

I checked it out and tried the autogeneration of What's changed. If you have any opinion about this, please let me know! @BECATRUE

kangz12345 commented 1 year ago

I added the bug tag because I got the following error when I tried to install qiwis by the recommended way in the README:

% pip install git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0
ERROR: Invalid requirement: 'git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0'
Hint: It looks like a path. File 'git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0' does not exist.

At first I thought this is because we did not publish the version 2.0.0, but I found that there was a typo: git_https. If I try it with git+https, I can see something more:

Collecting git+https://github.com/snu-quiqcl/qiwis.git@v2.0.0
  Cloning https://github.com/snu-quiqcl/qiwis.git (to revision v2.0.0) to /private/var/folders/w1/l25vrwxj6hg9ljrgry422bxc0000gn/T/pip-req-build-xrjcf8vb
  Running command git clone --filter=blob:none --quiet https://github.com/snu-quiqcl/qiwis.git /private/var/folders/w1/l25vrwxj6hg9ljrgry422bxc0000gn/T/pip-req-build-xrjcf8vb
  WARNING: Did not find branch or tag 'v2.0.0', assuming revision or ref.
  Running command git checkout -q v2.0.0
  error: pathspec 'v2.0.0' did not match any file(s) known to git
  error: subprocess-exited-with-error

  × git checkout -q v2.0.0 did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git checkout -q v2.0.0 did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Therefore, I will update git_https: -> git+https: in the README. Do you agree with this? @BECATRUE

BECATRUE commented 1 year ago

I checked it out and tried the autogeneration of What's changed. If you have any opinion about this, please let me know! @BECATRUE

Wow, I didn't know there was such a function. It's wonderful!

BECATRUE commented 1 year ago

I added the bug tag because I got the following error when I tried to install qiwis by the recommended way in the README:

% pip install git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0
ERROR: Invalid requirement: 'git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0'
Hint: It looks like a path. File 'git_https://github.com/snu-quiqcl/qiwis.git@v2.0.0' does not exist.

At first I thought this is because we did not publish the version 2.0.0, but I found that there was a typo: git_https. If I try it with git+https, I can see something more:

Collecting git+https://github.com/snu-quiqcl/qiwis.git@v2.0.0
  Cloning https://github.com/snu-quiqcl/qiwis.git (to revision v2.0.0) to /private/var/folders/w1/l25vrwxj6hg9ljrgry422bxc0000gn/T/pip-req-build-xrjcf8vb
  Running command git clone --filter=blob:none --quiet https://github.com/snu-quiqcl/qiwis.git /private/var/folders/w1/l25vrwxj6hg9ljrgry422bxc0000gn/T/pip-req-build-xrjcf8vb
  WARNING: Did not find branch or tag 'v2.0.0', assuming revision or ref.
  Running command git checkout -q v2.0.0
  error: pathspec 'v2.0.0' did not match any file(s) known to git
  error: subprocess-exited-with-error

  × git checkout -q v2.0.0 did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git checkout -q v2.0.0 did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Therefore, I will update git_https: -> git+https: in the README. Do you agree with this? @BECATRUE

You are right! I think I made a mistake in the process of moving the url.😥 I also agree with git+https: and is there any more review?

kangz12345 commented 1 year ago

I am okay with the release draft. Let's release it after I fix the README.

BECATRUE commented 1 year ago

Okay! Please fix it.

BECATRUE commented 1 year ago

I released v2.0.0 and installed it using pip install ..., but I failed importing it or using the qiwis command. Do you have the same symptom? @kangz12345

kangz12345 commented 1 year ago

I have the same issue, but for the command, it fails because of the importing issue (so the command is registered correctly). The problem is that the python cannot read the installed qiwis module.

BECATRUE commented 1 year ago

Probably, I found out a solution! Does the following command run correctly for your local?

pip install -e git+https://github.com/snu-quiqcl/qiwis.git@v2.0.0#egg=qiwis
kangz12345 commented 1 year ago

Okay I confirm that the solution works for me as well!