search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

add QtHandler for logging #188

Closed Aijuh closed 1 year ago

Aijuh commented 1 year ago

about issue #181

  1. import logging lib (line 6)
  2. import logger from qiwis (line 12)
  3. define Signaller and QtHandler (line 14-27).
  4. add Handler to logger (104-109). I don't know exact format for handler to deal with recording los, so format should be changed. handler is connected to addLog function, so when log emit message, it goes to addLog append to loggerFrame.
  5. add pyqtSlot before addLog function(line 115)
BECATRUE commented 1 year ago

First of all, please connect to the related issue using the appropriate keyword! The reference and other PRs such as snu-quiqcl/iquip#40 will help you.

BECATRUE commented 1 year ago

Also, the .idea directory seems to be added and I think you use IntelliJ or PyCharm IDEA😂 Please add it to .gitignore not to track more.

BECATRUE commented 1 year ago

Oh, you forked this repo to your own one! Please clone this, not fork because several GitHub actions are not available to your repo..

Also, #1 can help you about the branch name and commit message convention!