Becatrue/187/config json

snu-quiqcl / qiwis

QuIqcl Widget Integration Software

MIT License

5 stars 2 forks source link

Becatrue/187/config json #198

Closed BECATRUE closed 11 months ago

BECATRUE commented 11 months ago

This PR will close #187.

I just renamed setup.json to config.json.

kangz12345 commented 11 months ago

Aren't there any comments, for example how-to-use?

BECATRUE commented 11 months ago

I will fix the unittest errors😅

kangz12345 commented 11 months ago

Please merge this after @Aijuh reviews this.

BECATRUE commented 11 months ago

I didn't know that this PR needs my review. As far as I can check, there seems no problem.

Thanks for approving!

Until everyone submits his or her own first PR, Jiyong and I will merge it although there is only one approve. However, if you afford to leave reviews, reviewing may help you to understand codes!