search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Aijuh/199/log level selector #201

Closed Aijuh closed 11 months ago

Aijuh commented 11 months ago

Finish implementing log level selector as @kangz12345 requested as a week goal. Doubly checked comments and grammer issue. I will fix code right away if I missed something.

This closes #199

kangz12345 commented 11 months ago

Could you attach the screenshot of the GUI?

Aijuh commented 11 months ago

Updated codes by reflecting feedback.

  1. Removed the initialization function for setLevelBox and move its code to the class constructor.
  2. Follow comment guideline and naming convention.
  3. Change activate[str] to textActivated.
  4. Change nested if-else structure to dictionary.

Following is screenshot of the frame 캡처

Aijuh commented 11 months ago

Fixed mistakes.