search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Frame titles #231

Closed kangz12345 closed 7 months ago

kangz12345 commented 8 months ago

Feature you want to implement

For multi-frame apps, the frames have the same title, so it is hard to distinguish them when they are in tabs. I think we should support individual frame title naming.

How the feature is implemented

TBC

Additional context

In iquip, the device monitor app has three frames and they all have the same title "monitor".

BECATRUE commented 8 months ago

I have also agreed with this problem, too! But, I don't know what solution is the best yet..

BECATRUE commented 8 months ago

As I suggested last week, how about returning the following structure in frames()?

(("ttl monitor", self.ttlControllerFrame), ("dac monitor", self.dacControllerFrame), ...)
kangz12345 commented 8 months ago

Oh, what was the reason of using Tuple[Tuple[str, QWidget], ...] instead of Dict[str, QWidget]?

BECATRUE commented 8 months ago

I think there may be a case where we want to use duplicated frame name. But, if you think it is unnecessary, I will adopt your suggestion!

kangz12345 commented 8 months ago

I see! That's reasonable.