search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Destroy "center" apps when closed #233

Closed kangz12345 closed 8 months ago

kangz12345 commented 8 months ago

This closes #232.

This implementation is simple but does not cover all cases. For example, when an app has multiple frames, then the app will be destroyed even if just one frame is closed. However, the current frame-management system is not that flexible and we should do some work on it. I think it is okay for now to keep this implementation, but please let me know if you think different!

BECATRUE commented 8 months ago

I also agree with you, that the current frame management system has several problems.

But, I think removing only clicked frame may cause critical problems. In my idea, in order to remove all frames of the clicked app, it is okay to follow these steps:

  1. Connect closed signal to destroyApp()
  2. In removeFrame(), call frame.closeEvent().

How about this way?

kangz12345 commented 8 months ago

But, I think removing only clicked frame may cause critical problems

Could you explain more about this? Currently I connected destroyApp() to closed signal, so all the frames will be removed.

BECATRUE commented 8 months ago

Oh, I couldn't check the signal connection code.. Sorry for confusing. There is no problem!