search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

Use `requirements.txt` instead of direct installation #252

Closed BECATRUE closed 2 months ago

BECATRUE commented 2 months ago

This closes #251.

After merged, I will release a new version, v3.0.2.

BECATRUE commented 2 months ago

Which is better indicating each specific version or only library names?

The first helps to re-create the same environment, but even several submodules are shown, making it less legible. The second is legible, but it doesn't guarantee the same environment so later it may not work normally, like our PID GUI.

kangz12345 commented 2 months ago

Which is better indicating each specific version or only library names?

You mean the requirements.txt? I prefer the former. However, is it possible to omit the minor versions, e.g., 1.2.x? Too strict version requirement might cause dependency issues when many requirements come together.

BECATRUE commented 2 months ago

You mean the requirements.txt?

Yes!

is it possible to omit the minor versions, e.g., 1.2.x?

Sure. You can find the format of requirements.txt in here. Also, as you suggested, I will indicate the major(1st) and minor(2nd) version, not the patch(3rd) version.

BECATRUE commented 2 months ago

I updated it just now. @kangz12345