[CODE] `QWidget` layout initialization

[kangz12345]

Problem

Currently, we use _initWidget() method to initialize the layout of the custom widgets. This approach has controversial properties:

PROS

• Modular and reusable initializer
• Clearly show the layout-initializing part

  CONS

• Reusing the initializer is quite rare
• Just commenting might give the similar effect (readability)
• It violates the rule that all the attributes should be appear in __init__().
• In some sense, it forces the developer that this method can be reused. It seems too much requirement, and quite awkward considering the meaning of 'initialize'. Therefore, when we want to 'reset' the layout, a special method should be designed for such cases.

Suggestion

Do not use _initWidget(). Instead, write them directly in __init__() and use comments for readability. For example, if the original code below

class Foo(QWidget):
    def __init__(self, parent=None):
        super().__init__(parent=parent)
        self._initWidget()

    def _initWidget(self):
        self.button = QPushButton("button", self)
        # layout
        layout = QHBoxLayout(self)
        layout.addWidget(self.button)
        # signal connection
        self.button.click.connect(self._buttonSlot)

    def _buttonSlot(self):
        pass

would become

class Foo(QWidget):
    def __init__(self, parent=None):
        super().__init__(parent=parent)
        # widgets
        self.button = QPushButton("button", self)
        # layout
        layout = QHBoxLayout(self)
        layout.addWidget(self.button)
        # connect signals
        self.button.click.connect(self._buttonSlot)

    def _buttonSlot(self):
        pass

If you have any opinion, please leave comments!

[BECATRUE]

It looks a good idea! I applied this after numgen.

[Ahrrri]

I agree! In some of my previous codes, I used to write like that.

[BECATRUE]

The origianl apps should be updated in accordance with this form.