search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
6 stars 2 forks source link

Using type hints #78

Closed kangz12345 closed 1 year ago

kangz12345 commented 1 year ago

Discussed in https://github.com/snu-quiqcl/swift/discussions/75

Originally posted by **kangz12345** March 11, 2023 As you can see in [PEP 484 - Type Hints](https://peps.python.org/pep-0484), type hints can improve static analysis of the codes. Moreover, I think the code would be clearer and less documentation will be required. How about forcing to use type hints in our repo?
kangz12345 commented 1 year ago

@Ahrrri @BECATRUE May I start applying this to all modules? I will only add type hints, so only the import parts and definition parts would be modified. I will start this when both of you confirm OK.

BECATRUE commented 1 year ago

@Ahrrri @BECATRUE May I start applying this to all modules? I will only add type hints, so only the import parts and definition parts would be modified. I will start this when both of you confirm OK.

I agree with you!

kangz12345 commented 1 year ago

Oh I guess @Ahrrri is not able to work right now, so I will start!