search

snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
6 stars 2 forks source link

[BUG] How to exit mainWindow #86

Closed Ahrrri closed 1 year ago

Ahrrri commented 1 year ago

Describe the bug

I usually exit the mainWindow by just clicking the X button, but I see some warning/error message every time: QThread: Destroyed while thread is still running

Expected behavior

It should terminate without any message.

To Reproduce

Steps to reproduce the behavior:

  1. Execute our swift program as usual.
  2. Just click the X button to exit the program.

Expected causes and correction methods

Maybe we should stop all the active threads before terminating them?

Screenshots

image

Additional context

Add any other context about the problem here.

BECATRUE commented 1 year ago

I think it is because Buses do not stop immediately (It relies on timeout argument).

Like your idea, It is better not to show any message when X button is clicked!

kangz12345 commented 1 year ago

Since I implemented Bus, I will investigate this issue. Thank you for reporting!

BECATRUE commented 1 year ago

In a unit test, because of this error, the testing doesn't run correctly..

I think it is more important problem than I thought.

kangz12345 commented 1 year ago

95 resolved this issue, but it seems not a very accurate fix.

This will be studied further in #99.