snu-quiqcl / qiwis

QuIqcl Widget Integration Software
MIT License
5 stars 2 forks source link

`parent` parameter for `QObject`s #98

Closed kangz12345 closed 1 year ago

kangz12345 commented 1 year ago

Currently, there are many QObjects we have implemented, and each of them has the parent attribute since it is the one of QObject.

However, some of them do not have parent parameter at all (e.g., Bus), and the position of parent in the constructor is not consistent.

Therefore, I want to suggest that we put parent parameter at the last order, i.e., def __init__(self, ..., parent=None).

  1. Add parent parameter if there is not.
  2. Change the position of parent parameter to the last.

See also: #30