snuffyDev / Beatbump

Alternative YouTube Music frontend built with Svelte/SvelteKit 🎧
https://beatbump.io/
GNU Affero General Public License v3.0
1.07k stars 89 forks source link

[REWRITE PREVIEW] Need thoughts & feedback before releasing the update! #196

Open snuffyDev opened 1 year ago

snuffyDev commented 1 year ago

https://preview.beatbump.io/home

Give it a try, let me know if things break. Let me know of any issues, if/how/when things break, and any comments or feedback!

AFAICT things are pretty smooth, but y'all can break it better than me (that's a compliment, thank you for it!)

davidcollini commented 1 year ago

It seems that the remember last track toggle in settings turns off after reloading

davidcollini commented 1 year ago

https://github.com/snuffyDev/Beatbump/assets/89056889/b42dac2e-8762-401e-b330-ebb67e6c2de8

There's two bugs here, one at that top of the main page and the second on the bottom of the full screen player

snuffyDev commented 1 year ago

@IronMaltese Good catches!!! Appreciate you testing it out so far!

BrightDV commented 1 year ago

Hi, I just tried it, and the loading time seems really nice! However, I found 'some' issues:

Mobile - The cross to close the search overlay is a bit off.
Database related – not sure whether those are really bugs - Adding a favorite throws the following exception: ![image](https://github.com/snuffyDev/Beatbump/assets/92821484/75c92931-d59a-4298-96fe-9c7400123022) - When creating a playlist, the page doesn't refresh [Screencast.webm](https://github.com/snuffyDev/Beatbump/assets/92821484/49e3a1af-88e1-43f4-9193-e231792e3ec1) - Adding a song to a playlist doesn't save it neither, but there isn't a crash [Screencast.webm](https://github.com/snuffyDev/Beatbump/assets/92821484/86f6437c-fff2-4601-a84f-a05f9ec9cb66)
UI, not really bugs (Immersive queue toggle is on) - I find that the animation when exiting the player is a bit too long, but that is more subjective. - Otherwise, the transition should be reversed when exiting the full screen player. For the moment, when you exit the player, the UI disappears and then the background disappears, whereas, when you open it, they both shows up at the time. [Screencast.webm](https://github.com/snuffyDev/Beatbump/assets/92821484/7e28b29b-768b-497d-bb83-09f00a71fade)
Playback Updates URL setting – most buggy - I did not really understand how it works, because when enabling and then disabling the setting, the URL stills changes. - When enabled and clicking on the player, the URL correctly updates. - Then, if you skip the song **using the button**, the song played is some random song of the queue instead (between the 2nd and the 7th with my testing). - When exiting the player by clicking on it, the URL updates again with another URL (one of the song played before, not necessary in the queue). - Otherwise, the URL works well when opening it :)
Playback - The pause button does not work anymore, on both mobile and desktop.
snuffyDev commented 1 year ago

Appreciate the feedback, I'll iron these out!

snuffyDev commented 1 year ago

@IronMaltese fixed the second comment you left (the chips on the home page)

@BrightDV I fixed the refresh issue for playlists I believe. As for the other ones, I'm addressing them within the next couple days!

snuffyDev commented 1 year ago

Side note: working on a Spotify-like "multi-tab" feature

https://github.com/snuffyDev/Beatbump/assets/72365477/99e1a7a6-926e-429d-89c9-c80fd7d7081d

ghost commented 1 year ago

You forgot to add remove song from playlist button

BrightDV commented 1 year ago

I just found that the explicit symbol is always shown in the album view. For example, an album of Bach is shown as explicit... (without any explicit track). image

I double-checked on YouTube Music, and it is not shown as explicit. I guess that the icon is always shown.