snuk182 / aceim

Ace IM internet messenger (Android)
Apache License 2.0
6 stars 3 forks source link

Ace IM doesn't support the longer 16-character passwords introduced to ICQ in 2016 #5

Closed GrandAdmiralThrawn closed 7 years ago

GrandAdmiralThrawn commented 7 years ago

I believe it's just some truncates that would need to be updated from 8 to 16 symbols/characters.

Ace IM ICQ Module/src/aceim/protocol/snuk182/icq/inner/ICQServiceInternal.java line 668:

// ICQ does not support passwords longer than 8 symbols                         
if (pw != null && pw.length() > 8) {
  pw = pw.substring(0, 8);
}

and...

Ace IM ICQ Module/src/aceim/protocol/snuk182/icq/inner/dataprocessing/AuthenticationProcessor.java line 133:

// they don't support passwords longer than 8 symbols (facepalm)
if (pw.length > 8) {
  ln = 8;
} else {
  ln = pw.length;
}
snuk182 commented 7 years ago

Thanks a lot for the notification! Will check this as soon as possible.

GrandAdmiralThrawn commented 7 years ago

Thanks a lot!

I'd like to use your client because it seems to be the only one (?) that doesn't leak my credentials to external "proxy" servers to login to ICQ from there.

But I need long password support. :)

snuk182 commented 7 years ago

I need your help with testing, as I do not use ICQ for ages. Could you please remove .zip extension from an attachment and install and test it? It is already signed with a release certificate, so should not conflict with the previous installation and, if succeeded, will be uploaded to Play at once. PS It worked for me, I was even able to recall my ICQ password ^^ :) icq.apk.zip

GrandAdmiralThrawn commented 7 years ago

I just tested it with my long password, and can confirm that it's fully working! :) Thank you very much for 1.) actually fixing this and 2.) doing it so quickly as well!

snuk182 commented 7 years ago

https://github.com/snuk182/aceim/commit/5e4359c4461da672484f6ca73b1ee7c7dd0bf79c