snuk182 / goncurses

Automatically exported from code.google.com/p/goncurses
Other
0 stars 0 forks source link

HLine and VLine have different method signatures. #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.someWin.HLine(2, 1, gc.ACS_HLINE, x-3) // Compiles
2.someWin.VLine(1, 2, gc.ACS_VLINE, y-3) // Doesn't.
3.

What is the expected output? What do you see instead?
I expected those two to both compile, or neither of them to compile.

What version of the product are you using? On what operating system?
go1.0.3
latest source from goncurses

Please provide any additional information below.
Window.go:
func (w *Window) HLine(y, x int, ch Character, wid int) 
func (w *Window) VLine(y, x, ch, h int)

defs.go:
type Character int

I believe the proper solution for this is to set VLine to use Character instead 
of int. The defined characters (e.g. ACS_VLINE) are defined as type Character. 

Original issue reported on code.google.com by TheEpicS...@gmail.com on 29 May 2013 at 5:11

GoogleCodeExporter commented 9 years ago
Thanks for catching that. Fixed on tip.

Original comment by rthornto...@gmail.com on 1 Jun 2013 at 9:53