snurr-group / mofid

A system for rapid identification and analysis of metal-organic frameworks
https://snurr-group.github.io/mofid/
GNU General Public License v2.0
46 stars 24 forks source link

Document the round-tripping errors #7

Closed bbucior closed 5 years ago

bbucior commented 5 years ago

Many of the "errors" reported in the .json output from check_mof_linkers.py are non-intuitive, e.g. unk_pillar2 is referring to the ambiguity in pyridine vs. carboxylate termination for hMOF linkers (and is not actually an error). Some of the other validator codes in smiles_diff.py:DIFF_LEVELS also need to be documented more clearly. Going through these errors will make it easier to discuss the validation results.