[ET-231] Allow specifying node name in resource request

snuspl / cruise

Cruise: A Distributed Machine Learning Framework with Automatic System Configuration

Apache License 2.0

26 stars 2 forks source link

[ET-231] Allow specifying node name in resource request #1266

Closed wynot12 closed 6 years ago

wynot12 commented 6 years ago

Resolves snuspl/elastic-tables#231

This PR updates ExecutorManager and EvaluatorManager to let users specify node names in resource requests, which is supported by REEF. Though it has no usecase in our codebase yet, we've experienced that this feature is useful in heterogeneous environments, during preparation for the last conference.

wynot12 commented 6 years ago

By the way, I'm curious that the first line of PR comment can close issue in a remote repo.

wynot12 commented 6 years ago

!rebuild

wynot12 commented 6 years ago

I'll check the test failure.

wynot12 commented 6 years ago

!rebuild

wynot12 commented 6 years ago

@yunseong Would you please review this PR? This PR is quite simple :)

yunseong commented 6 years ago

Oh, sure. I missed this PR. Sorry for the delay :)