snuspl / dolphin

14 stars 2 forks source link

Support batch processing for deep neural networks #149

Closed beomyeol closed 8 years ago

beomyeol commented 8 years ago

This pull request introduces batch processing for deep neural networks. A batch size that is used for training can be specified in the neural network configuration file. The changes involved in this PR are the followings.

This closes #141.

jsjason commented 8 years ago

@beomyeol Sorry for the late pass. I've left some comments for you. The sample dataset works well on both groupcomm and paramserver configurations.

beomyeol commented 8 years ago

@jsjason Thank you for your review. I've addressed your comments and left a comment for the type of reduce values. Please take another look :)

jsjason commented 8 years ago

@beomyeol I've done a second pass and left two comments. Thanks!

beomyeol commented 8 years ago

@jsjason I've addressed your comments. Please review the changes.

jsjason commented 8 years ago

Looks great, will merge.