search

snuspl / dolphin

14 stars 2 forks source link

Use batch matrices in which each column represents an input instance. #163

Closed beomyeol closed 8 years ago

beomyeol commented 8 years ago

For batch processing, dolphin-dnn handles matrices in which each row represents an input instance. However, many linear algebra libraries such as netlib-java, jblas, and cuBLAS use column-major storage for the compatibility with Fortran environment. In this circumstance, retrieving each input instance from batch matrices requires the access of not contiguous memory (sequential access), which is inefficient. This pull request changes the batch matrix format that each column represents an input instance, not each row. This PR also include the change that MatrixFactory creates column vectors when it generates vectors.

This closes #155

jsjason commented 8 years ago

I'll do pass today.

jsjason commented 8 years ago

I've left a few comments, @beomyeol. Thanks.

beomyeol commented 8 years ago

@jsjason Thank you for the review. I've addressed some comments. Also, I left comments, too.

jsjason commented 8 years ago

Looks great. The sample configuration/dataset works well too. I'll merge this.