search

snuspl / dolphin

14 stars 2 forks source link

Implement padding in pooling layer #173

Closed ghost closed 8 years ago

ghost commented 8 years ago

This PR supports customizing padding in pooling layers. Now computations in pooling layers will be carried out with user-defined padding height and width. Padding parameters are added in classes related to pooling layer configuration files, computation process is a little modified to work well with padding and pooling layer with padding tests are added.

beomyeol commented 8 years ago

@seyounglee95 This looks good. I left some comments.

beomyeol commented 8 years ago

@seyounglee95 Can you remove the "Update master" commit and instead use 'rebase' command for including the changes in master branch?

beomyeol commented 8 years ago

@seyounglee95 This looks good! I've left the minor comments. I'll merge this as soon as you resolve them.

ghost commented 8 years ago

@beomyeol Thank you for your review. I pushed a commit. Please take a look :D

beomyeol commented 8 years ago

@seyounglee95 This looks nice. I'm merging this :D