snuspl / dolphin

14 stars 2 forks source link

[DOLPHIN-176] Create partitioned, queued, single-node parameter server #177

Closed bchocho closed 8 years ago

bchocho commented 8 years ago

Closes #176

I've done a simple performance comparison between PartitionedPS and ConcurrentPS by running the unit tests (1million reads + 1million writes) on my local laptop. The PartitionedPS has worse performance. Note that the ConcurrentPS can lose updates.

Also, the unit test does not include hash computation. A version of the test (not committed) that uses MurmurHash had an Avg runtime of 3s. However, this test also requires the key to be copied into a byte array, which we avoid in the actual implementation by using the original serialized value from the message.

jsjason commented 8 years ago

I did a pass and everything seems great. The new tests work as intended, and the existing dnn w/ ps example works well too. I'm merging this.