search

snuspl / dolphin

14 stars 2 forks source link

Update Apache REEF and Checkstyle. #182

Closed dongjoon-hyun closed 8 years ago

dongjoon-hyun commented 8 years ago

Apache REEF 0.15 is released at the maven central. We had better use 0.15. This PR also updates Checkstyle with the same version of REEF, and fixes some RedundantModifier errors accordingly.

This PR was tested by the following commands.

rm -rf ~/.m2/
mvn clean install
dongjoon-hyun commented 8 years ago

Hi, @jsjason . Could you review this when you have some time?

yunseong commented 8 years ago

@dongjoon-hyun Thanks! On behalf of @jsjason, I'll test & merge it.

yunseong commented 8 years ago

@dongjoon-hyun Tests passed on my local machine as well. For the minor nitpicks, I was thinking to make changes by myself, but it turns out to be unachievable as the branch is at your forked repo. I'm totally fine with the other changes, so could you let me know once you're done? Thanks!

dongjoon-hyun commented 8 years ago

Thank you for review, @yunseong ! I'll update soon.

dongjoon-hyun commented 8 years ago

The PR is updated. Thank you, @yunseong .

yunseong commented 8 years ago

@dongjoon-hyun Looks good. I'll merge this. Thanks!

dongjoon-hyun commented 8 years ago

Thank you, @yunseong ! :)