search

snuspl / dolphin

14 stars 2 forks source link

Add checkstyle #50

Closed bchocho closed 9 years ago

bchocho commented 9 years ago

REEF has added checkstyle (run via mvn checkstyle:checkstyle) and is in the process of getting the rules and code to pass. We should apply REEF's latest checkstyle to Dolphin as well. After that, we can work to remove the parts that don't comply.

This could be a good "introductory exercise" for CMSLab's summer interns to get familiar with Dolphin code, REEF style conventions, and GitHub collaboration.

jsjason commented 9 years ago

Good idea. One question, though: the issue you pointed out is still open, but the sub-tasks are all resolved. Is that issue about to be closed, @dafrista?

bchocho commented 9 years ago

I still see quite a few errors after running checkstyle on REEF. So, likely more sub-tasks will be opened and closed in the process.

kijungs commented 9 years ago

I added the checkstyle plugin. You can run checkstyle by mvn checkstyle:checkstyle

bchocho commented 9 years ago

Let's keep this open, and remember to merge in the full set of checkstyle changes when REEF-332 is resolved.