search

snuspl / dolphin

14 stars 2 forks source link

Too many files for one algorithm #55

Open jsjason opened 9 years ago

jsjason commented 9 years ago

Currently, a user needs to create many files (sometimes more than 10) to implement a single example using Dolphin. Although #7 solves this partially, #7 will not be resolved for a while. It'd be better if we can reduce the number of new files a user needs to code without the help of a DSL.

kijungs commented 9 years ago

Too many files also have bothered me. I think we can reduce the numbers by using inner classes. For example, it seems that ClusteringPreCommGroup and KMeansMainCommGroup do not need to be a separate file.

dongjoon-hyun commented 9 years ago

Hi, all. For this issue, is it possible to provide a single-file example?

jsjason commented 9 years ago

Hi, I guess we could pack the classes together to reduce the number of files, but I'm not sure about using only a single file. We would have to pack CtrlTask, CompTask, StageInfo, the Launcher class (e.g. PageRankREEF), and the parameter classes together in one file, and that would be pretty ugly. I think we should consider abstracting the interfaces a bit more, than trying to implement an example that uses only one file.