search

snuspl / dolphin

14 stars 2 forks source link

Comply with checkstyle #57

Closed bchocho closed 9 years ago

bchocho commented 9 years ago

Now that checkstyle has been imported from REEF, we can work to fix the parts that don't comply.

This could be a good "introductory exercise" for CMSLab's summer interns to get familiar with Dolphin code, REEF style conventions, and GitHub collaboration.

jsjason commented 9 years ago

I agree, but @kijungshin said that he'd like to work on fixing the checkstyle file. @kijungshin, could you kindly leave some parts for the other interns to finish?

kijungs commented 9 years ago

Correcting styles seems my responsibility, but it would be thankful if interns can help me. I will leave some parts for them.

      1. 오후 6:05에 "Jason (Joo Seong) Jeong" notifications@github.com님이 작성:

I agree, but @kijungshin https://github.com/kijungshin said that he'd like to work on fixing the checkstyle file. @kijungshin https://github.com/kijungshin, could you kindly leave some parts for the other interns to finish?

— Reply to this email directly or view it on GitHub https://github.com/cmssnu/dolphin/issues/57#issuecomment-114413106.

kijungs commented 9 years ago

@dafrista @jsjason I will address this today and tomorrow.

bgchun commented 9 years ago

:)

On Tue, Jun 23, 2015 at 6:12 PM, kijungshin notifications@github.com wrote:

Correcting styles seems my responsibility, but it would be thankful if interns can help me. I will leave some parts for them.

      1. 오후 6:05에 "Jason (Joo Seong) Jeong" <notifications@github.com

님이 작성:

I agree, but @kijungshin https://github.com/kijungshin said that he'd like to work on fixing the checkstyle file. @kijungshin https://github.com/kijungshin, could you kindly leave some parts for the other interns to finish?

— Reply to this email directly or view it on GitHub https://github.com/cmssnu/dolphin/issues/57#issuecomment-114413106.

— Reply to this email directly or view it on GitHub https://github.com/cmssnu/dolphin/issues/57#issuecomment-114415770.

Byung-Gon Chun