search

snuspl / dolphin

14 stars 2 forks source link

Comply with checkstyle #59

Closed kijungs closed 9 years ago

kijungs commented 9 years ago

Addresses #57.

I modified the source codes in the following packages so that they comply with checkstyle:

edu.snu.edu.reef.dolphin.core edu.snu.edu.reef.dolphin.groupcomm edu.snu.edu.reef.dolphin.parameters edu.snu.examples.simple edu.snu.snu.reef.dolphin.ml.algorithm.clustering edu.snu.snu.reef.dolphin.ml.algorithm.clustering.kmeans

I left the other source codes for the training of new interns.

bchocho commented 9 years ago

@kijungshin Great, thanks. Does this either partially or fully resolve #25?

kijungs commented 9 years ago

@dafrista Sadly, #25 is only partially resolved. I couldn't cover all the lists, and I couldn't pay enough attention to the detailed contents of comments. I just focused on complying with checkstyle.

jsjason commented 9 years ago

@kijungshin and I talked about the assignee of this PR, and given the circumstances we decided that I should take over this PR.

jsjason commented 9 years ago

I'm going to close this and create another one.