Unit tests for algorithms

[jsjason]

We don't have any unit tests for algorithms. We should add tests so that we can make sure the algorithms are actually performing intended behaviors.

[dongjoon-hyun]

Hi, @jsjason . For PageRank, I can add unit test, but I'm not sure about the dolphin's policy. Is it okay I do the following way?

• Make a folder for test suite.
  • /src/test/java/edu/snu/reef/dolphin/examples/ml/algorithms/graph
• Add the following files.
  • package-info.java
  • GraphTestSuite.java
  • PageRankTest.java

[dongjoon-hyun]

I made a PR #80 for further discussion. :)

[jsjason]

The test files should be in the same packages as the classes they are trying to test except under src/test/ and not src/main/. In that sense, the folder structure you proposed is great. I'll add comments on the PR itself.

[dongjoon-hyun]

Hi, @jsjason . If you don't mind, I will add two test suites for logistic/linear regression. I think integration tests are better than no tests. How do you think about that? We should have them before moving into REEF-0.13-SNAPSHOT aggressively. How do you think about these?

[jsjason]

Yes, in fact I'd be really thankful. We should definitely have tests for each algorithm before upgrading to the snapshot version.

[dongjoon-hyun]

Thanks. I will make a PR, soon.

[dongjoon-hyun]

Hi, @jsjason . Please review PR #91 .

[dongjoon-hyun]

And, I have no idea for clustering (K-means, EM). If you're okay, what about taking care them later after moving to REEF-0.13.