search

snuspl / dolphin

14 stars 2 forks source link

Apply checkstyle and fix license header format #65

Closed jsjason closed 9 years ago

jsjason commented 9 years ago

This pull request applies a checkstyle that is strongly based on REEF-332. The changes are from @dafrista's work.

Closes #57. Also closes #50.

bchocho commented 9 years ago

I will take a look at this.

bchocho commented 9 years ago

The changes look good. Also, the build works well. I'll merge.

Do we also want to add a rat check to the pom, to make sure all files are licensed? If so, we can do this in a separate PR.

jsjason commented 9 years ago

Yes, I was thinking of adding license checkers separately. Thanks, @dafrista.