search

snuspl / dolphin

14 stars 2 forks source link

Add argument maxNumEvalLocal to example usages in run scripts #89

Closed jsjason closed 9 years ago

jsjason commented 9 years ago

The current example usages in run scripts may fail because of the lack of providing the argument maxNumEvalLocal. This pull request adds the argument to each example usage.

Closes #86.

dongjoon-hyun commented 9 years ago

LGTM. :)

dongjoon-hyun commented 9 years ago

Oh, for consistency, could you add those into testPageRank, too?

dongjoon-hyun commented 9 years ago

Hi, @jsjason . Sorry, but I'll merge this. We can add maxNumEvalLocal later.

jsjason commented 9 years ago

Thanks, @dongjoon-hyun. Next time, please let me know if we are in a hurry.

dongjoon-hyun commented 9 years ago

Absolutely. Next time, I'll text you. :) By the way, could you change the due date of our first Milestone? It's inconsistent with our current status. You can freely update the milestone. I also add a new milestone between the existing two milestones for my issues. Is it okay?

jsjason commented 9 years ago

Yes, I noticed it too. I'll update it. The new milestone is great.

dongjoon-hyun commented 9 years ago

Thank you always!