search

snwagh / falcon-public

Implementation of protocols in Falcon
90 stars 46 forks source link

Remove fpermissive + fix assert error #3

Closed gmuraru closed 3 years ago

gmuraru commented 3 years ago

I tried running the experiments on different setup and it seems I got an assertion error. Looking more into it, it seems the problem was at the optimizations level - leaving only O0 in the FLAGS (from the Makefile) made the code work <--- but this is not the best speed at which the code could run.

The best would be obtained compiling with O3.

The -fpermissive flag seems to put the compiler and optimizer into a hard place, because it seems it does some changes and everything goes hayware.

In this PR I did:

snwagh commented 3 years ago

I would generally keep the -fpermissive flag but I do like the fix so I'll go ahead and pull it.