search

snwh / faba-icon-theme

Faba is a sexy and modern icon theme with Tango influences.
Other
71 stars 17 forks source link

broken symlink: /usr/share/icons/Faba/16x16/places/folder-drag-accept.svg -> folder-open.svg #61

Open fossfreedom opened 7 years ago

fossfreedom commented 7 years ago

Debian has reported the following: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857212

EDIT: is this issue fixed by this commit? https://github.com/snwh/faba-icon-theme/commit/e50649d0171fd8cce42404c7c5002d77710ffcfc

Hi,

during a test with piuparts I noticed your package ships (or creates) a broken symlink.

From the attached log (scroll to the bottom...):

0m39.7s ERROR: FAIL: Broken symlinks: /usr/share/icons/Faba/16x16/places/folder-drag-accept.svg -> folder-open.svg

The package ships these related files:

-rw-r--r-- 1 root root 6904 May 29 2016 /usr/share/icons/Faba/16x16/status/folder-open.svg -rw-r--r-- 1 root root 5714 May 29 2016 /usr/share/icons/Faba/24x24/places/folder-open.svg -rw-r--r-- 1 root root 5742 Jun 21 2016 /usr/share/icons/Faba/256x256/actions/folder-open.png -rw-r--r-- 1 root root 719 Jun 21 2016 /usr/share/icons/Faba/32x32/actions/folder-open.png -rw-r--r-- 1 root root 11298 May 29 2016 /usr/share/icons/Faba/48x48/status/folder-open.svg -rw-r--r-- 1 root root 1348 Jun 21 2016 /usr/share/icons/Faba/64x64/actions/folder-open.png lrwxrwxrwx 1 root root 15 Jun 21 2016 /usr/share/icons/Faba/16x16/places/folder-drag-accept.svg -> folder-open.svg lrwxrwxrwx 1 root root 15 Jun 21 2016 /usr/share/icons/Faba/24x24/places/folder-drag-accept.svg -> folder-open.svg -rw-r--r-- 1 root root 11278 May 29 2016 /usr/share/icons/Faba/48x48/status/folder-drag-accept.svg

There seems to be an inconsistency in the paths: 16x16/places vs. 16x16/status faba-icon-theme_4.1.2-1.log.gz

simonvanderveldt commented 7 years ago

This also gets flagged by Gentoo's QA checks

 * QA Notice: Symbolic link /usr/share/icons/Faba/16x16/places/folder-drag-accept.svg points to /usr/share/icons/Faba/16x16/places/folder-open.svg which does not exist.
>>> /usr/share/icons/Faba/16x16/places/folder-drag-accept.svg -> folder-open.svg

Seems like there's indeed a mixup, with the same icons and symlinks showing up in different folders (places, status and actions). If they need to exist in all three both the symlinks and the files symlinked to should exist.