search

snwh / faba-mono-icons

Faba Mono (Panel) Icons
GNU General Public License v3.0
28 stars 3 forks source link

Chrome and Hangouts icon fix #8

Closed marcinant closed 10 years ago

marcinant commented 10 years ago

faba3

Chrome and Hangouts icons are fixable but only with some scripting. Would you accept debian postinst script replacing wrong icons as a solution?

snwh commented 10 years ago

No. It's against policy to modify system files or files of another package. But like the others I can provide icons for those if you'd like to do it yourself.

snwh commented 10 years ago

Which have been added in the latest commit as google-chrome-panel & google-hangouts-panel.

marcinant commented 10 years ago

There is no deb package for google hangouts. It's an extension installed from Chrome Web Store in userspace.

So, there is no modification of files from another package. But it requires modification of files in user home directory which is wrong as well.

snwh commented 10 years ago

Where are the files?

marcinant commented 10 years ago

On my system path is for Chrome stable ~/.config/google-chrome/Default/Extensions//nckgahadagoaajjgafhacjanaoiihapd/2014.710.434.3_0/images_3/*.png

and for Chrome unstable:

~/.config/google-chrome-unstable/Default/Extensions//nckgahadagoaajjgafhacjanaoiihapd/2014.710.434.3_0/images_3/*.png

and for Chromium:

~/.config/chromium/Profile 1/Extensions//nckgahadagoaajjgafhacjanaoiihapd/2014.710.434.3_0/images_3/*.png

That's for hangouts icon. I don't know where these "chrome/chromium" icon are, yet.

I'm not sure what would be best method to override them. My ideas are:

  1. Overwrite files in user space with postinst script (easy solution but unstable and ugly as hell).
  2. Provide custom Hangouts package as system wide extension as described here: https://developer.chrome.com/extensions/external_extensions (not tested, I don't know if it would work) and patch with custom icon path. I also don't know if it's allowed by Google license.
  3. Write some custom extension to Chrome that would detect Hangouts and override it's icon path. (not sure if it's doable, if it's worth the effort).

Anyway these are just my "bright ideas" ;)

marcinant commented 10 years ago

Last option would be off course to add icons to theme and ask Google to provide theme support in their extension. There are some problems though.

  1. They use greyed icon to signal "offline" status, green icons means that user is logged in.
  2. This extension is "broken by design". Just take a look at this screenshot:

faba4

From left to right: fixed Spotify icon, fixed VirtualBox icon, fixed Google Drive icon, Dropbox and....

Chromium icon + Chromium Hangouts with user not logged in, Chrome Stable icon + Chrome stable Hangouts with "online" status, Chrome Unstable icon + Chrome Unstable Hangouts with "online" status.

This is screwed up. I'll try to find a way to contact with Google and file bug report.

https://chrome.google.com/webstore/detail/hangouts/nckgahadagoaajjgafhacjanaoiihapd/details?utm_campaign=en&utm_source=en-et-na-us-oc-webstrhm&utm_medium=et https://support.google.com/hangouts/?p=help# https://productforums.google.com/forum/#!categories/hangouts