snwh / moka-icon-theme

Moka Icon Theme
http://snwh.org/moka
Other
452 stars 91 forks source link

overly large app-icon display ubuntu 16.10 #279

Open fossfreedom opened 8 years ago

fossfreedom commented 8 years ago

Hi,

for ubuntu 16.10 they (I think) are shipping libreoffice compiled with the gtk3 libraries.

Unfortunately with Moka the app-icon as displayed in budgie-desktop is huge. This displays ok with other iconsets such as humanity and gnome.

Any thoughts why the app-icon is displaying like this?

fossfreedom commented 7 years ago

ok - have tried also fiddling with adding MinSize and MaxSize values in the 16x16/apps section of index.theme - didnt seem to help :/

fossfreedom commented 7 years ago

also - on a side note - paper icon theme also suffers from this issue :(

snwh commented 7 years ago

I know. I'm not aware what the problem is because it's not all apps. My suspicion is it's a window manager thing.

ghost commented 7 years ago

The same happens in Ubuntu GNOME 16.10 - so it might not be just one window manager. Surprisingly, there are other icon sets which work just fine with this.

fossfreedom commented 7 years ago

ok - just linking the same issue but with the paper-icon-theme:

fossfreedom commented 7 years ago

@snwh under Ubuntu 17.04 - If I delete the Directory List line in Moka's index.theme and regenerate the icon-cache this fixes the large icon issue in Libreoffice So what is the purpose of this Directory List line? Is it safe to delete?

snwh commented 7 years ago

@fossfreedom it lists the directories. ;)

fossfreedom commented 7 years ago

:) given that I can delete that, refresh the icon cache, logout and login and all icons appear to still be displayed correctly, do icon-themes still need to explicitly define the directory list ... I don't really understand why deleting that line appears to fix this issue.

snwh commented 7 years ago

@fossfreedom for whatever reason some applications pull in the high DPi versions of icons (@2x) deleting that line means the theme index excludes all the @2x folders and therefore "fixes" this issue but this would cause issues on high DPI displays.

fossfreedom commented 7 years ago

damn :( thanks for the explanation.

fossfreedom commented 7 years ago

Sam, as you can gather I have zero icon theme knowledge ...!

I've hacked this index.theme file - merged from numix-icon-theme with Moka - this appears to work ok. Thoughts?

https://gist.github.com/fossfreedom/13a68ffe08c860784c83abda9e9b05cc

snwh commented 7 years ago

@fossfreedom it appears to work because it's the same as deleting the line –Numix has a different directory structure than Moka so that edited version is pointing at non-existent directories.

snwh commented 7 years ago

I still maintain the issue is with the affected apps and not the icon theme. If it were an icon theme issue it would be a universal problem –i.e. all apps would display the icons incorrectly.

fossfreedom commented 7 years ago

ah well ... can't say I didn't try!

fossfreedom commented 7 years ago

Sam - I have rebuilt from the latest sources - it appears your revacuuming stuff yesterday has fixed this issue!

fossfreedom commented 7 years ago

ah - the change of "scalable" to "Scalable" in index.theme is the fix here.