snwh / moka-icon-theme

Moka Icon Theme
http://snwh.org/moka
Other
450 stars 91 forks source link

PPA: Moka icons won't build on Artful and newer #391

Closed wfwf1997 closed 6 years ago

wfwf1997 commented 6 years ago

The package from PPA suffers from building failure on Artful and newer version of Ubuntu. According to the build log, meson is missing for building them. Is it possible to add meson to build dependencies to make auto build work again?

snwh commented 6 years ago

It doesn’t need meson to build the packages and the packaging instructions don’t require them. I don’t know why the build server is trying that.

wfwf1997 commented 6 years ago

The project has changed from autotools to meson as build system, so meson becomes a build dependency. In the newer version of debhelper, it can detect meson as build system and then auto configure it. However, debhelper provided in Xenial is an older version which lacks support in meson. That is why packages in old version of Ubuntu seems to be built successfully. But the .deb generated takes only several KiBs, which means it is not properly packaged as well.
I think either add meson to build dependencies or manually override dh_install target can solve the problem.

snwh commented 6 years ago

Exactly, I don’t need meson to build anything. Can I override that in debhelper?

wfwf1997 commented 6 years ago

Make rules in debian folder like this and everything got solved:

#!/usr/bin/make -f

#export DH_VERBOSE = 1
%:
        dh $@

override_dh_auto_configure:

override_dh_missing:
        dh_missing --fail-missing

This makes dh_auto_configure do nothing. And original dh_install can put every icon just in place.

snwh commented 6 years ago

Ahhhh, that's the bit I don't have in the rules. I keep the packaging code on launchpad since I don't wanna pollute the main repo: https://code.launchpad.net/~moka/moka-icon-theme/+git/packaging/+ref/master

wfwf1997 commented 6 years ago

Remember to remove the whole override_dh_install section or it will do nothing when installing.

snwh commented 6 years ago

I have an install file though

wfwf1997 commented 6 years ago

Problem is that you also overrode dh_install behavior by using override_dh_install, but install file is actually handled by the original dh_install script. So you need to remove this section or it would put nothing to the package.

snwh commented 6 years ago

I wasn't having problems with the install process however

wfwf1997 commented 6 years ago

It is built successfully. But just have a look at the buildlog, it contains no icons at all:

moka-icon-theme_5.4.518-201806241606~daily~ubuntu18.10.1_all.deb
----------------------------------------------------------------

 new debian package, version 2.0.
 size 2076 bytes: control archive=828 bytes.
     399 bytes,    12 lines      control              
     158 bytes,     2 lines      md5sums              
     298 bytes,    19 lines   *  postinst             #!/bin/sh
      44 bytes,     0 lines   *  prerm                
 Package: moka-icon-theme
 Version: 5.4.518-201806241606~daily~ubuntu18.10.1
 Architecture: all
 Maintainer: Sam Hewitt <sam@snwh.org>
 Installed-Size: 11
 Depends: faba-icon-theme
 Section: gnome
 Priority: optional
 Homepage: https://github.com/snwh/moka-icon-theme
 Description: Moka Icon Theme
  Moka is a stylized Tango-esque Linux desktop icon set.
  They are designed to be clear, simple and consistent.

drwxr-xr-x root/root         0 2018-06-24 16:11 ./
drwxr-xr-x root/root         0 2018-06-24 16:11 ./usr/
drwxr-xr-x root/root         0 2018-06-24 16:11 ./usr/share/
drwxr-xr-x root/root         0 2018-06-24 16:11 ./usr/share/doc/
drwxr-xr-x root/root         0 2018-06-24 16:11 ./usr/share/doc/moka-icon-theme/
-rw-r--r-- root/root       311 2018-06-24 16:11 ./usr/share/doc/moka-icon-theme/changelog.Debian.gz
-rw-r--r-- root/root       682 2018-06-24 16:11 ./usr/share/doc/moka-icon-theme/copyright
drwxr-xr-x root/root         0 2018-06-24 16:11 ./usr/share/icons/
snwh commented 6 years ago

:joy:

snwh commented 6 years ago

Does anyone enjoy debian packaging??

wfwf1997 commented 6 years ago

Actually I was an Arch Linuxer and also enjoy using Fedora. The packaging system of Debian is the most complex among the three. In Arch Linux you just need a PKGBUILD and in Fedora/RHEL you need a .spec, but in Debian, too many things to deal with. Ahhh, so annoying.

snwh commented 6 years ago

@wfwf1997 I know, I used to do both of those as well for this project and related projects and they were so much easier to deal with.

snwh commented 6 years ago

Alright! that buildlog looks right now, thanks for your help I was having the same problem across all my icon sets.

snwh commented 6 years ago

Things seem to be working. Heck that would have been a simple fix had I found it, online documentation on debian packaging is horrible.