search

snwh / paper-icon-theme

Paper Icon Theme
http://snwh.org/paper
Creative Commons Attribution Share Alike 4.0 International
1.57k stars 140 forks source link

Folder Color Support #586

Closed alex285 closed 7 years ago

alex285 commented 7 years ago

can we have foldercolor [1] support, so we can highlight some folders? it is the only reason i dont use Paper icon set, although i love it!

[1] http://foldercolor.tuxfamily.org/

image shows what this extension does in La Capitaine icon theme that supports it flat-plat-lacapitaine

snwh commented 7 years ago

Not possible since my understanding of folder-colors is that it replaces an icon's colour in an SVG icon asset directly (which I frown upon) and Paper's icons are PNG (for quality reasons).

Coloured folder icons are shipped in Paper (e.g.folder-red), whether or not folder-colors can do anything with that I do not know.

alex285 commented 7 years ago

@snwh this is how it works http://bazaar.launchpad.net/~costales/folder-color/trunk/view/head:/README

i will try to use it in Paper and see

snwh commented 7 years ago

@alex285 alright, I did some investigating. An pushed a possible fix to master if you want to test it.

snwh commented 7 years ago

It is only for normal folders, I'm not gonna make a coloured set of all the special home directory folders (at this time) since that'd be a few hundred unnecessary icons.

alex285 commented 7 years ago

@snwh not working here, the "colors menu" doesnt pop up, does it work for you?

bilelmoussaoui commented 7 years ago

Hey, The Folder color extension won't work as the icons extensions are hardcoded https://bazaar.launchpad.net/~costales/folder-color/trunk/view/head:/nautilus-extension/folder-color.py just search for ".svg". I don't really understand why those extensions are needed anyway, but this should be reported upstream

snwh commented 7 years ago

Yeah I'm finding the same. This extension is rather crude, hardcoding extensions, asking for non-standard icons names. Closing as it's not "Paper should support Folder Colors", "Folder Colors should support Paper."

alex285 commented 7 years ago

@bil-elmoussaoui you know what you need to do now :)

bilelmoussaoui commented 7 years ago

@alex285 Already porvided an easier way to do that screenshot from 2017-06-13 18-43-58 screenshot from 2017-06-13 18-44-14

snwh commented 7 years ago

I've already filed a bug upstream on Folder Colors: https://bugs.launchpad.net/folder-color/+bug/1697735

alex285 commented 7 years ago

@bil-elmoussaoui oops i missed that! super! i'll try in a bit! here for anyone else! https://github.com/bil-elmoussaoui/nautilus-folder-icons

snwh commented 7 years ago

And suggested the dev account for icons of the name folder-[color] since those ship in many themes already to support KDE/Dolphin.

costales commented 7 years ago

Hi, In version 0.0.80+ Paper should work by default :) Remember that you'll need to update Folder Color from the PPA ( +info here: foldercolor.tuxfamily.org ) Best regards.