search

snyball / hawck

Key-rebinding daemon for Linux (Wayland/X11/Console)
BSD 2-Clause "Simplified" License
562 stars 15 forks source link

Improve doc with elements discussed in #75 #79

Closed eddy-geek closed 1 year ago

eddy-geek commented 1 year ago

Sorry for the extra formatting done by vscode (which does not impact rendering).

snyball commented 1 year ago

Looked into it and the journal-spam is actually a bug, the intended behavior is to only log the error if it changes:

https://github.com/snyball/Hawck/blob/1dff066bd341804245c87e1771d8f52fe5474b2b/src/UNIXSocket.hpp#L177

The constructor of SystemError is what is actually logging the error: https://github.com/snyball/Hawck/blob/1dff066bd341804245c87e1771d8f52fe5474b2b/src/SystemError.hpp#L45

So the fix is simple for that, I'll just move the construction of SystemError into that condition.

snyball commented 1 year ago

Also, all the paragraphs in README.md should be hard-wrapped at column 80.

eddy-geek commented 1 year ago

I believe I've addressed all points raised.

snyball commented 1 year ago

I believe I've addressed all points raised.

Neat! I'll do another review then

eddy-geek commented 1 year ago

addressed again. please kindly consider merging and then rewording as you want. with github editing you don't even need to leave the browser :-) :-)