snyball / hawck

Key-rebinding daemon for Linux (Wayland/X11/Console)
BSD 2-Clause "Simplified" License
562 stars 15 forks source link

[proposal] let 'replace' remap keys even with modifers #85

Closed eddy-geek closed 1 year ago

eddy-geek commented 1 year ago

in my opinion if I write key "b" => replace "a" then I expect pressing Shift+b to write symbol A ; Currently it writes a and I expect Control+b to send Control-a (typically select-all shortcut) ; Currently it writes a

of course If I really want exact text then I can still do key "b" => insert "a"

I really don't see many uses for the current behavior, but I understand it may be better to instead add new method perhaps named remap, so as to not break existing code (also since sub and replace are aliases one of them could be kept as-is?)

snyball commented 1 year ago

I don't actually remember what the intention was, but I think it would be OK to just remove the wrapping withCleanMods like you did.

If you add a file called changelogs/changelog_0.8.0.md, with the same layout as the 0.6.0 one, and a section for "Breaking Changes" then I think this is ready to merge.

likern commented 1 year ago

Just came across this project spontaneously and I like it! Wish this project a success. As I see right now it only allows basic remapping.

If you would like to further extend it and add new features I would highly recommend to look at https://github.com/UltimateHackingKeyboard/firmware/blob/master/doc-dev/user-guide.md and https://github.com/UltimateHackingKeyboard/firmware/blob/master/doc-dev/reference-manual.md.

A lot (!) of thought was put into this remapping engine. You could even try to take it's major code. I think it should work.

snyball commented 1 year ago

Looks good now!