Closed eddy-geek closed 1 year ago
I don't actually remember what the intention was, but I think it would be OK to just remove the wrapping withCleanMods
like you did.
If you add a file called changelogs/changelog_0.8.0.md
, with the same layout as the 0.6.0
one, and a section for "Breaking Changes" then I think this is ready to merge.
Just came across this project spontaneously and I like it! Wish this project a success. As I see right now it only allows basic remapping.
If you would like to further extend it and add new features I would highly recommend to look at https://github.com/UltimateHackingKeyboard/firmware/blob/master/doc-dev/user-guide.md and https://github.com/UltimateHackingKeyboard/firmware/blob/master/doc-dev/reference-manual.md.
A lot (!) of thought was put into this remapping engine. You could even try to take it's major code. I think it should work.
Looks good now!
in my opinion if I write
key "b" => replace "a"
then I expect pressingShift+b
to write symbolA
; Currently it writesa
and I expectControl+b
to sendControl-a
(typically select-all shortcut) ; Currently it writesa
of course If I really want exact text then I can still do
key "b" => insert "a"
I really don't see many uses for the current behavior, but I understand it may be better to instead add new method perhaps named
remap
, so as to not break existing code (also sincesub
andreplace
are aliases one of them could be kept as-is?)