snyk-tech-services / snyk-prevent-gh-commit-status

Other
0 stars 1 forks source link

release changes and fixes #37

Closed aarlaud closed 3 years ago

aarlaud commented 3 years ago

What this does

Release changes and fixes in snyk-delta Adds passIfNoBaseline option to not fail in case there is not baseline/monitored project snapshot to compare against and the current test contains vulns. It typically helps on the first iterations when we try to get the Snyk mechanic in and get a monitored snapshot.

aarlaud commented 3 years ago

:tada: This PR is included in version 2.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jeetchoudhary commented 3 years ago

@mathild3r we don't run snyk-delta explicitly, I believe snyk_prevent_commit-status invokes it internally. will passing --setPassIfNoBaseline to snyk_prevent_commit-status work?

mathild3r commented 3 years ago

@jeetchoudhary it won't, setPassIfNoBaseline is a snyk-delta option, and it's set to false. so if you use snyk-prevent-commit-status on its own the default behaviour will apply. it will fail if there is no baseline.

jeetchoudhary commented 3 years ago

ohh. that's a bummer then. Users using snyk-prevent-commit-status alone are left with no option then. Is there is a way you can support it?

jeetchoudhary commented 3 years ago

we had a discussion with Andre and he is aware of the fact that Salesforce uses snyk-prevent-commit-status alone

aarlaud commented 3 years ago

we're fixing that. looking to push out a version shortly.

aarlaud commented 3 years ago

Check out the v2.0.6 @jeetchoudhary , should do the trick.