search

snyk / gradle-plugin

Snyk Gradle Plugin - Scanning and monitoring your dependencies for security vulnerabilities from Gradle
Other
17 stars 19 forks source link

CliDownloader#downloadLatestVersion() uses internal Gradle classes #3

Open bmuschko opened 3 years ago

bmuschko commented 3 years ago

While convenient, internal Gradle classes should never be used as they can introduce breaking changes with a new Gradle runtime version and therefore may break the consumer of this plugin. Example: https://github.com/snyk/gradle-plugin/blob/master/src/main/java/io/snyk/gradle/plugin/CliDownloader.java#L66

The same behavior can be observed in SnykBinaryTask.

bmvermeer commented 3 years ago

Great suggestion

trevjonez commented 3 years ago

Seems this should be closed. Neither of the classes in the OP are using anything but public gradle API now.